Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limitCountRedis: add option to disable x-envoy-ratelimited #835

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

limitCountRedis: add option to disable x-envoy-ratelimited #835

wants to merge 3 commits into from

Conversation

yizhibian
Copy link

Related to #617
use enable_limit_quota_headers as ratelimited option

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 10, 2025
spacewander
spacewander reviewed Jan 10, 2025
View reviewed changes
Copy link
Member

@spacewander spacewander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to use separate option (like Envoy's disable_x_envoy_ratelimited_header) and add test to cover this feature.

@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.34%. Comparing base (b25067b) to head (19531ea).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #835      +/-   ##
==========================================
- Coverage   85.45%   85.34%   -0.11%     
==========================================
  Files         141      141              
  Lines        8407     8408       +1     
==========================================
- Hits         7184     7176       -8     
- Misses        968      974       +6     
- Partials      255      258       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 11, 2025
@spacewander
Copy link
Member

@yizhibian
Please update the doc to make CI pass.

@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 13, 2025
@yizhibian
Copy link
Author

@yizhibian Please update the doc to make CI pass.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacewander spacewander spacewander left review comments

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yizhibian @spacewander